Re: [PATCH] 2.5.35 atm driver compile fix

[Adrian Bunk]

On Mon, 16 Sep 2002, Mitchell Blank Jr wrote:

> Adrian Bunk wrote:
> > This change results in a compile error in the ATM drivers:
>
> Yes, this was a bug in the ATM drivers... they really should have been using
> do_gettimeofday() instead of touching xtime anyway.
>
> Here's a patch that should fix up all these ATM compile errors.  Linus,
> please apply

Thanks for this patch, the next compile error is that compilation of
firestream.c fails at all occurences of func_enter:

<--  snip  -->

...
  gcc -Wp,-MD,./.firestream.o.d -D__KERNEL__
-I/home/bunk/linux/kernel-2.5/linux-2.5.35/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer
-fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=k6 -nostdinc -iwithprefix include  -g  -DKBUILD_BASENAME=firestream
-c -o firestream.o firestream.c
firestream.c: In function `fs_open':
firestream.c:870: called object is not a function
firestream.c:870: parse error before string constant
...
make[2]: *** [firestream.o] Error 1
make[2]: Leaving directory `/home/bunk/linux/kernel-2.5/linux-2.5.35/drivers/atm'

<--  snip  -->

> -Mitch  (deadbeat ATM maintainer)

I didn't Cc you because you are only listed as PPP OVER ATM (RFC 2364)
maintainer in MAINTAINERS. Do you now maintain the complete ATM subsystem?
If yes, could you send a patch for MAINTAINERS?

cu
Adrian

-- 

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
								Alan Cox