Re: [patch 5/9]Four new i2c drivers and __init/__exit cleanup to

[Jeff Garzik]

Albert Cranford wrote:
> Hello Linus,
> New I2C drivers that have been adjusted after Russell King comments of August.
> o i2c-algo-8xx.c
> o i2c-pport.c
> o i2c-adap-ibm_ocp.c
> o i2c-pcf-epp.c
> o Add new drivers to Config.in and Makefile.
> o Add new drivers to i2c-core for initialization.
> o Remove EXPORT_NO_SYMBOLS statement from i2c-dev, i2c-elektor and i2c-frodo.
> o Cleanup init_module and cleanup_module adding __init and __exit to most drivers.
> o Adjust i2c-elektor with cli/sti replacement.
> 
> 
> ------------------------------------------------------------------------
> 
> --- linux/drivers/i2c/i2c-dev.c.orig	2002-09-05 11:23:38.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-dev.c	2002-09-05 11:25:21.000000000 -0400
> @@ -544,8 +544,6 @@
>  	return 0;
>  }
>  
> -EXPORT_NO_SYMBOLS;
> -
>  #ifdef MODULE

kill ifdef

>  MODULE_AUTHOR("Frodo Looijaard <[e-mail]> and Simon G. Vogl <[e-mail]>");
> --- linux/drivers/i2c/i2c-elektor.c.orig	2002-09-10 22:31:34.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-elektor.c	2002-09-10 22:31:58.000000000 -0400
> @@ -291,8 +291,6 @@
>  	return 0;
>  }
>  
> -EXPORT_NO_SYMBOLS;
> -
>  #ifdef MODULE
>  MODULE_AUTHOR("Hans Berglund <[e-mail]>");
>  MODULE_DESCRIPTION("I2C-Bus adapter routines for PCF8584 ISA bus adapter");

kill ifdef

> --- linux/drivers/i2c/i2c-frodo.c.orig	2002-09-05 11:23:59.000000000 -0400
> +++ linux-2.5.34/drivers/i2c/i2c-frodo.c	2002-09-05 11:25:28.000000000 -0400
> @@ -97,8 +97,6 @@
>  	return (i2c_bit_add_bus (&frodo_ops));
>  }
>  
> -EXPORT_NO_SYMBOLS;
> -
>  static void __exit i2c_frodo_exit (void)
>  {
>  	i2c_bit_del_bus (&frodo_ops);
> @@ -111,8 +109,6 @@
>  MODULE_LICENSE ("GPL");
>  #endif	/* #ifdef MODULE_LICENSE */

kill MODULE_LICENSE ifdef

>  
> -EXPORT_NO_SYMBOLS;
> -
>  module_init (i2c_frodo_init);
>  module_exit (i2c_frodo_exit);
>