Re: New large block-device patch for 2.5.31+bk

Peter Chubb (peter@chubb.wattle.id.au)
Fri, 23 Aug 2002 09:27:53 +1000


>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:

Christoph> I don't have much comments left :) What about moving the
Christoph> sector_t typedef completly to <asm/types.h>? Looks like
Christoph> the cleanest solution to me.

I'd rather not, because most of the architectures just need the
generic version. I *hate* unnecessarily duplicated code.

Christoph> I also wonder whether CONFIG_LBD might want to move to
Christoph> arch/*/config.

I thought about that, but couldn't work out any way to make it appear
in the right place in the menus --- it's really a block device
configuration option that happens to be needed only for a few
architectures.

Christoph> An a little suggestion: you could feed that patch to Linus
Christoph> in pieces. The printk cleanups might be a good start.

Will do...

--
Dr Peter Chubb				    peterc@gelato.unsw.edu.au
You are lost in a maze of BitKeeper repositories, all almost the same.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/