Re: [Ibm-specweb99] Re: [Lse-tech] Re: (RFC): SKB Initialization

[Nivedita Singhvi]

Dave, 

Just FYI, the profile of the second link (*mala*) is the
one youre quoting first in this msg, and the profile of
the first link (presumably prior to mala's patch) is the
one you've quoted second in the mail. Hopefully, the links
are just misnamed, and the profiles listed before/after are
the right ones here in the mail. :).

It would be useful to know how consistent these profiles are,
and the variance youre seeing with these runs, before reaching any 
conclusions..

For instance, skb_release_data(), which wasnt altered,
increased from 7259 to 13,322, which is on par with the
kind of gain expected by the patch in the other functions.
So is this just normal variance, or a result of the patch?

Looking at most of the Specweb profiles and networking
in general, and because so much here depends on which cpu
code gets run on, and cache behaviour, I'd say youre going
to get a lot of variance...

thanks,
Nivedita

Quoting Dave Hansen <[e-mail]>:

[snip] 

> First of all, the patch doesn't apply at all against the current 
> bitkeeper tree.  I can post the exact one I used if you like.
> 
> I tried this under our Specweb99 setup.  Here's a snippet of 
> readprofile with, then without the patch:
> 
>    8788 __kfree_skb
>    8970 mod_timer
>    9095 file_read_actor
>   10778 alloc_skb
>   10905 skb_clone
>   11368 e1000_clean_tx_irq
>   13595 e1000_intr
>   18367 csum_partial_copy_generic
>   27848 e1000_xmit_frame
> 225838 poll_idle
> 623160 total                                      0.4107
> 
> alloc:free ratio: 1.226
> (__kfree_skb+alloc_skb)/total = 3.14%
> 
>    4535 alloc_skb
>    4559 do_tcp_sendpages
>    4596 e1000_clean_rx_irq
>    4847 dev_queue_xmit
>    5020 tcp_clean_rtx_queue
>    5155 batch_entropy_store
>    5165 kmalloc
>    5309 tcp_transmit_skb
>    6060 do_schedule
>    6138 qdisc_restart
>    6235 tcp_v4_rcv
>    6393 kfree
>    6787 do_gettimeofday
>    7089 __d_lookup
>    7810 ip_queue_xmit
>    8303 skb_clone
>    8858 file_read_actor
>    8885 mod_timer
>    9375 .text.lock.namei
>   10267 .text.lock.dec_and_lock
>   10936 e1000_clean_tx_irq
>   13001 __kfree_skb
>   13322 skb_release_data
>   13562 e1000_intr
>   18099 csum_partial_copy_generic
>   27447 e1000_xmit_frame
> 225023 poll_idle
> 628695 total                                      0.4143
> 
> alloc:free ratio: 0.348
> (__kfree_skb+alloc_skb)/total = 2.79%
> 
> You can see the entire readprofile here:
> 
http://www.sr71.net/~specweb99/run-specweb-100sec-2400-2.5.31-bk+4-kmap
-08-22-2002-11.20.17/
> 
http://www.sr71.net/~specweb99/run-specweb-100sec-2400-2.5.31-bk+4-kmap
-mala-08-22-2002-11.44.25/
> No, I don't know why I have so much idle time.
> 
> -- 
> Dave Hansen
> [e-mail]
> 
> _______________________________________________
> ibm-specweb99 mailing list
> [e-mail]
> http://ltc.linux.ibm.com/mailman/listinfo/ibm-specweb99
> 
>