Re: New large block-device patch for 2.5.31+bk

[Christoph Hellwig]

On Thu, Aug 22, 2002 at 03:08:29PM +1000, Peter Chubb wrote:
> 
> Hi,
> 	Here's the latest large-block device patch.  Expect more
> changes as Al Viro continues his partition cleanup (I've just
> converted int *xxx_sizes to sector_t *xxx_sizes; he's gradually
> getting rid of xxx_sizes[] altogether --- and a good thing too!).
> 
> I think I've addressed all the comments I've received so far, except
> for the request for something that works on 2.4.X.
> 
> The patch enables support for large (>2TB) block devices for all platforms
> where sizeof(long)==8, and via a config option for power-PC and IA32.
> It's been tested on IA64 and IA32 only.

I don't have much comments left :)  What about moving the sector_t typedef
completly to <asm/types.h>?  Looks like the cleanest solution to me.

I also wonder whether CONFIG_LBD might want to move to arch/*/config.

An a little suggestion:  you could feed that patch to Linus in pieces.
The printk cleanups might be a good start.