Re: [PATCH] rmap bugfix, try_to_unmap

[Daniel Phillips]

On Monday 19 August 2002 22:15, Rik van Riel wrote:
> On Mon, 19 Aug 2002, Daniel Phillips wrote:
> > On Monday 12 August 2002 16:58, Rik van Riel wrote:
> > >  	case SWAP_FAIL:
> > >  		ret = SWAP_FAIL;
> > > -		break;
> > > +		goto give_up;
> >
> > Yes, I looked at that many times while reading the break as a 'break
> > from loop' every time.  Using the same keyword to mean 'stop looping'
> > and 'endcase' was, by any measure, a stupid idea.
> 
> What's even more curious is that 'continue' has the exact
> same effect on 'switch' ...

Come to think of it, what you want there is:

 	case SWAP_FAIL:
  		return SWAP_FAIL;

-- 
Daniel