Re: Generic list push/pop

[Daniel Phillips]

On Sunday 18 August 2002 21:28, you wrote:
> Hi,
> 
> On Sun, 18 Aug 2002, Daniel Phillips wrote:
> > #define push_list(_LIST_, _NODE_) \
> > 	_NODE_->next = _LIST_; \
> > 	_LIST_ =_NODE_;
> > 
> > #define pop_list(_LIST_) ({ \
> > 	typeof(_LIST_) _NODE_ = _LIST_; \
> > 	_LIST_ = _LIST_->next; \
> > 	_NODE_; })
> 
> How do we protect against:
> 
> push_list(getFuckingList(), node);
> node_t node = pop_list(getFuckingList());
> 
> ? Couldn't this break the _LIST_ = _LIST_->next; ?

Yes, there are various sloppy things there, including missing parens
around args and missing wrapper around the statement.  It should also
be written to evaluate each arg exactly once.  With all that done it
will be even uglier but at least it will work reliably.

-- 
Daniel