Re: 2.4.20-pre2 NFS OOPS on sparc64

[Neil Brown]

On Tuesday August 13, [e-mail] wrote:
>    From: Meelis Roos <[e-mail]>
>    Date: Tue, 13 Aug 2002 19:21:30 +0300 (EEST)
> 
>    2 oopses from stock 2.4.20-pre2 during NFS startup 9mountd etc killed as
>    a result). Looks like a bad use of bitops inside sunrpc. egcs64 compiler
>    from debian.
>    
> Neil, sk_flags in struct svc_sock may not be an int, bitops require
> "long".

I knew that.... but obviously not at the right time.  Thanks.

Now if only Linus has told me (like you did) instead of just making
the change himself in 2.5, I would have got it right in 2.4..

Anyway, I'll make sure it gets to Marcelo (if he hasn't picked it up
already) and will feel suitably chastised.

NeilBrown

> 
> --- include/linux/sunrpc/svcsock.h.~1~	Tue Aug 13 10:37:10 2002
> +++ include/linux/sunrpc/svcsock.h	Tue Aug 13 10:37:15 2002
> @@ -22,7 +22,7 @@
>  
>  	struct svc_serv *	sk_server;	/* service for this socket */
>  	unsigned char		sk_inuse;	/* use count */
> -	unsigned int		sk_flags;
> +	unsigned long		sk_flags;
>  #define	SK_BUSY		0			/* enqueued/receiving */
>  #define	SK_CONN		1			/* conn pending */
>  #define	SK_CLOSE	2			/* dead or dying */