Re: [PATCH] cdrom sane fallback vs 2.4.20-pre1

[James Bottomley]

> > -             if (ret) {
> > +             if (ret && sense.sense_key==0x05 && sense.asc==0x20 && sense.ascq==0x00) {
> 
> Do you really need to hardcode this values ?

We have no #defines for the asc and ascq codes (they are interpreted in 
constants.c but the values are hardcoded in there too).  There is a #define 
for sense_key 0x05 as ILLEGAL_REQUEST in scsi/scsi.h, but these #defines have 
annoyed a lot of people by being rather namespace polluting.

James