Yes it is obviously correct.
> BTW, are there any TRM290 owners using 2.5.30? Old code set length to
> ((length >> 2) - 1) << 16, while new code does not have special handling
> for TRM290. Or do I miss something?
The new code is overwriting those values in the host controller driver
itself.
> And BTW#2, mine problematic Toshiba disk works fine with PDC20265 with
> 512B request size... It breaks with i845 and i440BX, under any UDMA.
Hmm... It is very well possible that the Toshiba doesn't like the
fact that the intel chipsets cheat and do something like UDMA88 instead
of UDMA100. Could you verify this by checking whatever forcing them to
UDMA66 helps please? Vojtech?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/