Re: [PATCH] Toshiba Laptop Support and IRQ Locks

Alan Cox (alan@lxorguk.ukuu.org.uk)
02 Aug 2002 18:55:39 +0100


On Fri, 2002-08-02 at 17:03, John Weber wrote:
> Hi,
>
> Toshiba laptop support is broken. Here's my rookie attempt at fixing it.

Looks basically sound. You probably want to use spinlock_irqsave - the
spin locks are less overhead than the reader/writer locks and you don't
really seem to be using it for anything else. I'm assuming we want the
irqsave to block interrupts because the I/O cycles might have to happen
one after another - if not they could be relaxed - perhaps Jonathan
knows ?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/