Re: [PATCH]: linux-2.5.30uc0 MMU-less patches

[gerg]

Hi David,

David Woodhouse wrote:
> [e-mail] said:
> 
>> I have coded a generic MTD map driver to replace the old crufty
>>blkmem driver. The blkmem driver will be going away in future patches.

Did you have a look at uclinux.c, that is the one I was referring
to here?

> --- linux-2.5.30/drivers/mtd/maps/snapgear-uc.c	Thu Jan  1 10:00:00 1970
> +++ linux-2.5.30uc0/drivers/mtd/maps/snapgear-uc.c	Mon Jul 15 21:29:25 2002
> +#ifdef CONFIG_NFTL
> +#include <linux/mtd/nftl.h>
> +#endif
> 
> You shouldn't need that.

There is one board setup supported by this that uses DiskOnChip
(the CONFIG_SH_SECUREEDGE5410 define). But your probably right,
it wouldn't need nftl.h.

> +int flash_eraseconfig(void)
> +{
> 
> This will cause an oops if it gets woken by a signal -- you leave and the 
> the 'struct erase_info' on your stack frame, which you passed to the 
> asynchronous erase call, goes bye bye.

OK, I'll get that fixed.

> +		ROOT_DEV = MKDEV(NFTL_MAJOR, 1);
> 
> Oh, I see -- if we fail to find a file system we recognise on the NOR 
> flash, try booting from DiskOnChip. Does this really live here?

Well, it actually support for a completely different board - it
doesn't have NOR flash at all.

This code supports a wide variety of boards, with mixtures of
NOR flash and/or DiskOnChip.

> --- linux-2.5.30/drivers/mtd/mtdblock.c	Fri Aug  2 15:15:41 2002
> +++ linux-2.5.30uc0/drivers/mtd/mtdblock.c	Fri Aug  2 16:00:13 2002
> -		if (req->flags & REQ_CMD)
> +		if (! (req->flags & REQ_CMD))
> 
> Yes.
> 
> +#ifdef MAGIC_ROM_PTR
> +static int
> +mtdblock_romptr(kdev_t dev, struct vm_area_struct * vma)
> 
> No, although the fix I'm happy with is going to take a while to get 
> implemented so maybe in the short term. This is likely to get rejected on 
> other grounds anyway; perhaps separate it and don't submit it for inclusion 
> just now?

Sounds good to me. The most important is the uclinux.c support.
Since that means I can get rid of the blkmem driver all together
from the uClinux patches.

Thanks
Greg

------------------------------------------------------------------------
Greg Ungerer  --  Chief Software Wizard        EMAIL:  [e-mail]
Snapgear Pty Ltd                               PHONE:    [phone]
825 Stanley St,                                  FAX:    [phone]
Woolloongabba, QLD, 4102, Australia              WEB:   www.snapgear.com