Re: [PATCH] eepro 0.13a

[Jeff Garzik]

Andi Kleen wrote:
>>@@ -633,37 +633,37 @@
>> 
>> 	i = inb(dev->base_addr + ID_REG);
>> 	printk(KERN_DEBUG " id: %#x ",i);
>>-	printk(KERN_DEBUG " io: %#x ", (unsigned)dev->base_addr);
>>+	printk(" io: %#x ", (unsigned)dev->base_addr);
>> 
>> 	switch (lp->eepro) {
>> 		case LAN595FX_10ISA:
>>-			printk(KERN_INFO "%s: Intel EtherExpress 10 ISA\n at %#x,",
>>+			printk("%s: Intel EtherExpress 10 ISA\n at %#x,",
>> 					dev->name, (unsigned)dev->base_addr);
> 
> 
> [more cases deleted]
> 
> This surely can't be right. Why are you dropping all the KERN_*s ?

I have a feeling he ran a diff between his "pure" copy and the kernel 
copy, and assumed the output was correct....

	Jeff