Re: [PATCH] vfs_read/vfs_write small bug fix (2.5.29)

[Paul Larson]

On Mon, 2002-07-29 at 16:22, Linus Torvalds wrote:
> Does this work for you? If not, that implies that glibc may be missing a
> 
> 	if (pos < 0) {
> 		errno = EINVAL;
> 		return -1;
> 	}
> 
> in its implementation of the pread/pwrite shim layer.
> 
> (Or maybe glibc doesn't know that the kernel pread/pwrite system calls 
> were always 64-bit clean, and it just happened to work).
> 
> 		Linus
No, with just this patch it still fails on pread02 and pwrite02.

# ./pread02
pread02     1  PASS  :  pread() fails, file descriptor is a PIPE or
FIFO, errno:29
pread02     2  FAIL  :  pread() returned 0, expected -1, errno:22

# ./pwrite02
pwrite02    1  PASS  :  file descriptor is a PIPE or FIFO, errno:29
caught SIGXFSZ
pwrite02    2  FAIL  :  specified offset is -ve or invalid, unexpected
errno:27, expected:22
pwrite02    3  PASS  :  file descriptor is bad, errno:9

Paul Larson
Linux Test Project
http://ltp.sourceforge.net