Re: Linux 2.4.19-rc3-ac4

[Erik Andersen]

On Mon Jul 29, 2002 at 01:40:58PM -0400, Alan Cox wrote:
> [+ indicates stuff that went to Marcelo, o stuff that has not,
>  * indicates stuff that is merged in mainstream now, X stuff that proved
>    bad and was dropped out]
> 
> This patch contains SiS IDE updates. Usual caveats apply. The HP merge is
> now down to 5340 lines.
> 
> Linux 2.4.19rc3-ac4
> o	Lots of gcc 3.1 __FUNCTION__ warning fixes	(me)

make -C drm modules
make[3]: Entering directory `/usr/src/linux/drivers/char/drm'
gcc -D__KERNEL__ -I/usr/src/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -Os -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4  -DMODULE  -nostdinc -I /usr/lib/gcc-lib/i386-linux/2.95.4/include -DKBUILD_BASENAME=radeon_drv  -c -o radeon_drv.o radeon_drv.c
In file included from radeon_drv.c:34:
ati_pcigart.h: In function `radeon_ati_pcigart_init':
ati_pcigart.h:96: parse error before `)'
ati_pcigart.h:102: parse error before `)'
ati_pcigart.h:107: parse error before `)'
ati_pcigart.h:115: parse error before `)'
ati_pcigart.h:135: parse error before `)'
[---------------tons of similar noise snipped-------------------]
In file included from radeon_drv.c:108:
drm_stub.h: In function `radeon_stub_register':
drm_stub.h:125: parse error before `)'
drm_stub.h:133: parse error before `)'
drm_stub.h:137: parse error before `)'
make[3]: *** [radeon_drv.o] Error 1
make[3]: Leaving directory `/usr/src/linux/drivers/char/drm'
make[2]: *** [_modsubdir_drm] Error 2
make[2]: Leaving directory `/usr/src/linux/drivers/char'
make[1]: *** [_modsubdir_char] Error 2
make[1]: Leaving directory `/usr/src/linux/drivers'
make: *** [_mod_drivers] Error 2

The problem seems to be that 
    DRM_ERROR( "no scatter/gather memory!\n" );

expands into
    printk("<3>"  "[" "drm"  ":%s] *ERROR* "   "cannot allocate PCI GART page!\n"   ,  ) ;

I think the __FUNCTION__ changes to DRM_ERROR and friends in drmP.h 
look awfully bogus.

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--