Re: [PATCH] automatic initcalls

Patrick Mochel (mochel@osdl.org)
Mon, 29 Jul 2002 11:56:10 -0700 (PDT)


> > -__initcall(spawn_ksoftirqd);
> > +fs_initcall(spawn_ksoftirqd);
>
> See, this is exacly the kind of thing that makes me doubt that the
> current "magic 7 initcall levels" are useful in the long term 8(

I agree that that is abusing the interface. WTF does spawn_ksoftirqd have
to do with filesystems?

The purpose of the initcall levels in the first place was to start
removing the ugly conditional calls in init/main.c I looked at what was
being called, and came up with names to describe what was being done at
each phase. There happened to be seven of them.

I knew from the start that people would feel that they were more important
that others, and leapfrog their initcalls before everyone else. We're
egotistical; that's what we do. But remember, just because it's there,
doesn't mean you have to use it.

That said, it's been a while since I've really looked at it. I favor a
mechanism for getting the ordering right. I don't really like having to
specify the dependencies in the definitions; I think it's kinda ugly and
wonder if there is an automatic way to resolve them. I don't have any
ideas, nor the time to play with it, so it remains still just a pipe
dream...

-pat

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/