Re: [PATCH] 2.5.28 small REQ_SPECIAL abstraction

[Marcin Dalecki]

James Bottomley wrote:
> [e-mail] said:
> 
>>Ok... I had two issues with the patch. 1) it did
>>	rq->flags &= REQ_QUEUED; 
> 
> 
> Yes, that was inherited from SCSI.  Previously it just cleared flags and then 
> set REQ_BARRIER|REQ_SPECIAL.  Now I needed to clear flags but preserve the 
> state of REQ_QUEUED, which is what that code is doing, otherwise the 
> blk_rq_tagged() would always fail lower down.
> 
> 
>>I'll back down, it's not a matter of life and death after all. Here's
>>the minimal patch that corrects the flag thing, and also makes
>>blk_insert_request() conform to kernel style. Are we all happy? 
> 
> 
> I'm happy (as long as it works on my SCSI card).
> 
> James

BTW.> I just noticed quite a "bunch" of single line functions in the
SCIS code. Sort of like:

int scsi_warp_foo(xxx)
{
      foor(whis and that);
}.

EXPORT_SYMBOL(scsi_wrap_foo);

All of them just eat space on the stack during execution.
Would you mind moving them over to scsi.h and making them static inline?

We all know that SCSI has sometimes problems with the limited stack 
depth during kernel code execution time, esp on "Black Big Boxen"...
Well the above "tactics" doesn't hlep buch, but a bit is a bit is a bit 
and "a man/farmer doesn't foregive someone still alive"... :-).