Re: SiS 5513 ATA133 support patch for 2.4.19-rc3-ac3

[L.C. Chang]

SiS 745/746/750/... like 645/646/650/..., is an independent north bridge
which may be paired with SiS 961a/961b/962(963).
And as you known, the northbridge ID alone was not able to distinguish
the UDMA support in those chipset family. So I changed all of them
to ATA133 in my patch. When ATA133 family found in
pci_init_sis5513(), I would look for further information to determine
which family it belongs to (ATA100/ATA133a/ATA133).

L.C.

> On lun, jui 29, 2002 at 09:11:34 +0200, Daniela Engert wrote:
> > On Mon, 29 Jul 2002 01:37:54 +0200, Lionel Bouton wrote:
> >
> >
> > Lionel,
> >
> > as you already figured out, looking at the northbridge IDs is simply
> > not sufficient to find out which capabilities and register layout the
> > IDE controller in the southbridge (no matter if integrated or external)
> > has.
> >
> > Some comments:
> >
> > 1) the 745 has an integrated southbridge and an ATA/100 capable IDE
> > controller
> >
>
> I believed so too, but Lei-Chun patch changed it to ATA133.
> Lei-Chun, could you tell us what we can expect from 745 chips ?
>
> > 2) the 646 (and most likely the 645 and others as well) may be paired
> > with a 961 (ATA/100) or 961B (ATA133) MutIOL southbridge with different
> > register programming values.
> >
> > Thus simply ripping out some northbridge IDs wouldn't prevent
> > corruption problems.
> >
>
> I don't see why (unless you refer to the 962/963 problem I did mention).
> If we remove the IDs, the chips will be detected as SiS5513 (ATA_16). If
> I'm correct, in this mode (only allowing PIO modes and SW/MW DMA modes)
> all chips are OK.
> I didn't dig in all specs to check each config register change, but all I
> saw was OK and I *never* received any data corruption report for a chip
that
> was configured as original SiS5513 (though I have many reports of bad
> performance due to PIO modes being used in such cases).
>
> LB.