Race in open(O_CREAT|O_EXCL) and network filesystem

[Jan Hudec]

Hi all,

maybe I'm blind, but I think there is a race featuring
open(O_CREAT|O_EXCL) and nfs or any other network fs.

What may happen is:

client A: open_namei looks up the inode
	driver queries server and gets ENOENT
client B: open_namei looks up the inode
	driver queries server and gets ENOENT
client A: open_namei calls create method
	driver requests file to be created and is successful
client B: open_namei calls create method
	dirver requests file to be created and since it does not know,
	cant specify exclusion, thus is succesful
client A: open_namei does no more checks and thus open succeeds
client B: open succeeds too here - and it shouldn't

Since many applications rely on this working correctly (especialy
mailboxes are locked using exclusive creates and mounting them over NFS
is quite common).

So, can someone please answer:

1) Is there some reason this can't happen that I overlooked?
2) If it is a problem (comment in NFS suggest so), I can see two ways of
handling this. Either pass the flags to the create method, or restart
the open when create returns EEXISTS. Which one would be prefered?
3) How to fix NFS to add exclude flag to the NFSv3 request?

-------------------------------------------------------------------------------
						 Jan 'Bulb' Hudec <[e-mail]>