Re: [PATCH] 2.5.29 sound/oss/trident.c [2/2] remove cli/sti calls

Zwane Mwaikambo (zwane@linuxpower.ca)
Mon, 29 Jul 2002 10:56:01 +0200 (SAST)


On Mon, 29 Jul 2002, Muli Ben-Yehuda wrote:

> On Mon, Jul 29, 2002 at 10:08:52AM +0200, Zwane Mwaikambo wrote:
> > On Sun, 28 Jul 2002, Muli Ben-Yehuda wrote:
> >
> > > +
> > > + spin_unlock_irqrestore(&card->lock, flags);
> > >
> > > restore_flags(flags);
> > > }
> >
> > hmm...
>
> grrr, harmless I think, but thanks for spotting it.

But still racy, i think i may try a test run with some code to poison
flags after its already been used to xxx_restore.

Cheers,
Zwane

-- 
function.linuxpower.ca

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/