On Sun, 28 Jul 2002 13:28:34 +0200 (CEST) Ingo Molnar <mingo@elte.hu> wrote:
>
>
> the attached patch fixes two things:
>
> - a TLS related bug noticed by Arjan van de Ven: apm_init() should set up
> all CPU's gdt entries - just in case some code happens to call in the
> APM BIOS on the wrong CPU. This should also handle the case when some
> APM code gets triggered (by suspend or power button or something).
Except, if you read the comment, we never do APM BIOS calls on anything
but CPU 0. On SMP the only APM BIOS operation we allow is power off
and we have code to ensure we are on CPU 0 before we do that ...
> - compilation problem
I would prefer a patch (see the post by Muli Ben-Yehuda
<mulix@actcom.co.il>) that defines num_possible_cpus() or equivalent, the
current code (using num_online_cpus()) is broken in places.
I need to revisit all this code in light of CPU hotplug ...
-- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/