Re: Event API changes - EVIOCGID

Johann Deneux (johann.deneux@laposte.net)
Sun, 28 Jul 2002 13:38:08 +0300


Brad Hards wrote:
> On Sun, 28 Jul 2002 18:22, Vojtech Pavlik wrote:
>
> [...]
>
>>__u* is used extensively in the input API anyway, so you'd have to
>>explain it to userspace programmers nevertheless. So I prefer keeping
>>the input.h include use just one type of explicit sized types.
>
> So do I, and it had better be a standard type.
>
> Note that the input API does *NOT* use __u* extensively. In fact
> if you take out the force feedback stuff (which Johannes already

(Just a detail: my name is Johann)

> agreed to change:), this is the *only* _u* usage in any part of the
> input API.
>

I did this change in the past, but it was undone (not by me), as it
would break user-space applications. I definitely agree to use uint16_t.

>
>>Sure, we can change them all to uint*_t, but then do it all at once and
>>provide a satisfactory explanation for it. ;)
>
> I am doing it all. Johannes agreed to the change, and I did the only
> other required entry. If Johannes agrees, I'll do the trivial changes
> for force-feedback.

Ok with me.

> The reason why I am not doing it all at once is to provide patches
> that do one API change at a time. Or, depending on how you look
> at it, I did the only change all-at-once, and you reverted it :)
>
> Brad
>

-- 
Johann Deneux

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/