Re: [patch] scheduler, migration startup fixes, 2.5.29

Ingo Molnar (mingo@elte.hu)
Sun, 28 Jul 2002 09:30:50 +0200 (CEST)


On Sun, 28 Jul 2002, Rusty Russell wrote:

> This is, AFAICT, overkill (the UP compilation fix appreciated though).
>
> When a new CPU comes up, there is a semaphore which is held through the
> notifier, so you can't have two CPUs come up at once.
>
> Therefore, the new migration thread is either started on a completely
> active cpu (ie. there's a migration thread on that CPU to use), or it's
> already on the new cpu, in which case set_cpus_allowed is a noop.
>
> What am I missing? [...]

you are missing the following situation: if a newly forked migration
thread is put on a non-boot CPU that is already started up. Because it's
the target CPU's migration thread that counts - and since the newly online
CPU doesnt have one, we could deadlock.

so current BK is the right behavior.

Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/