[PATCH] fix APM notify of apmd for on-AC/on-battery transitions

Cort Dougan (cort@fsmlabs.com)
Fri, 26 Jul 2002 14:33:45 -0600


This patch fixes a problem with Sony Vaio laptops where they don't notify
the kernel of power source change events. That means apmd is never told
and many of the apmd features can't be used.

The Sony Vaio that I have doesn't send APM events to the kernel telling it
about 'going on battery' or 'going on AC power' events. It will register
them correctly if they're queried but it won't asynchronously send an event
so the kernel never tells apmd about it.

This patch fixes the situation by checking against the last known power
state (and power source) in the check_status() call.

This was tested on a Sony Vaio z505js, model PCG-5201 and it works
beautifully. I'm told other Vaio notebooks have this same problem. Now,
Vaio users can setup apmd to aggressively try to save power when on battery
or perform other crazy tasks.

This patch is against v2.4.16 but applies to newer kernels as well.

diff -Nru a/arch/i386/kernel/apm.c b/arch/i386/kernel/apm.c
--- a/arch/i386/kernel/apm.c Fri Jul 26 14:29:55 2002
+++ b/arch/i386/kernel/apm.c Fri Jul 26 14:29:55 2002
@@ -1313,6 +1313,34 @@
break;
}
}
+
+ /*
+ * The Sony Vaio doesn't seem to want to send us a notify
+ * about AC line power status changes. So, we have to keep track
+ * of it by hand and emulate it here.
+ * -- Cort <cort@fsmlabs.com>
+ */
+ if ( is_sony_vaio_laptop ) {
+ static int last_status = 0;
+ u_short status, bat, life;
+
+ /* get the current power state */
+ if ( apm_get_power_status(&status, &bat, &life) !=
+ APM_SUCCESS ) {
+ printk("%s:%s error checking power status\n",
+ __FILE__,__FUNCTION__);
+ }
+
+ /* has the status changed since we were last here? */
+ if (((status >> 8) & 0xff) != last_status) {
+ last_status = (status >> 8) & 0xff;
+
+ /* fake a APM_POWER_STATUS_CHANGE event */
+ send_event(APM_POWER_STATUS_CHANGE);
+ queue_event(APM_POWER_STATUS_CHANGE, NULL);
+ }
+
+ }
}

static void apm_event_handler(void)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/