Re: [PATCH] IDE 104

[Marcin Dalecki]

Alan Cox wrote:
> On Fri, 2002-07-26 at 08:23, Marcin Dalecki wrote:
> 
>>- Make the bit-sliced data types in hdreg.h use the bit-slice data types
>>   instead of the generic ones. This makes clear that those are supposed
>>   to be register masks.
> 
> 
> Because its an external API it needs to remain constant. Swapping

???

The only thing which is really 'external API' there is the declaration
of the HDIO_XXX ioctl and among them in reality only HDIO_GETGEO 
      is really used outside the scope of the dreddy hdparm application. 
And
99% of times its usage is bogous anyway. Or do you know any better
examples I'm not aware of?

The remainings will be moved away from there soon becouse it doesn't
make any sense to include this at every single place out there where
HDIO_GETGEO is the needed declaration. If some application needs ATA 
command macros - it should come with they own header declaring them 
instead of peeing in to the kernel becouse they don't depend on the
kernel in question. They are cut in stone at www.t13.org ;-).

> uchar/uint looks fine and the structure is off the drive anyway. However
> they should be __u16 __u8 __u32 so that C libraries and apps can still
> use the header (its __u16 because 'u16' cannot be exposed to user space
> directly or via libc)

I know - see above.