Re: [PATCH] drivers/ide/qd65xx: no cli/sti (2.4.19-pre3 & 2.5.28)

[Vojtech Pavlik]

On Thu, Jul 25, 2002 at 10:25:26AM +0200, Marcin Dalecki wrote:
> Vojtech Pavlik wrote:
> > On Thu, Jul 25, 2002 at 01:45:00AM +0200, Samuel Thibault wrote:
> > 
> >>Hello,
> >>
> >>Here are patches for 2.4.19-pre3 & 2.5.28 which free them from using
> >>cli/sti in qd65xx stuff.
> > 
> > 
> > Cool.
> > 
> > 
> >>(also using ide's OUT_BYTE / IN_BYTE btw)
> > 
> > 
> > In my opinion this doesn't make sense. The qd65xx is a VESA Local Bus
> > only hardware and is very very unlikely to be used on anything else than
> > an x86, where these defines are needed. Also, the ports written to are
> > not a part of the IDE controller region, so the IN_BYTE/OUT_BYTE macros
> > might not work there if it was ever used on a non-x86 machine. Also, it
> > makes the code less readable.
> 
> Amen. BTW> I think proper fix is to simple *remove* the cli() cti()
> commands. They don't make much sense in first place.

Yes. Btw, it would be nice if the IDE core guaranteed that no two tuning
functions would be ever run at the same time. No performance hit, life a
lot easier.

-- 
Vojtech Pavlik
SuSE Labs