Re: [patch] big IRQ lock removal, 2.5.27-G0

[Oleg Nesterov]

Hello.

> > Then local_bh_enable() has a small preemptible window between
>
> i dont think getting a preemption before softirqs are processed is a big
> problem. Such type of preemption comes in form of an interrupt, which

Ah, yes...

> > But in irq_exit() case interrupt context may be preempted
>
> okay - i've fixed irq_exit() once more in -G4

found G5, your forgot to add preempt_disable() in irq_exit()

 #define irq_exit()
 do {
+               preempt_disable();
                preempt_count() -= IRQ_EXIT_OFFSET;
                if (!in_interrupt() && softirq_pending(smp_processor_id()))

Oleg.