Re: [patch] cli()/sti() cleanup, 2.5.27-A2

Ingo Molnar (mingo@elte.hu)
Mon, 22 Jul 2002 15:26:57 +0200 (CEST)


On Mon, 22 Jul 2002, Christoph Hellwig wrote:

> > i agree mostly, but i do not agree with __irq_save() and irq_save().
> > What's wrong with "flags_t irq_save_off()" - the name carries the proper
> > meaning, and it also harmonizes with irq_off().
>
> but not with irq_restore :) maybe irq_restore_on() although the on
> is implicit.

no, the on is not implicit at all. If you restore into a disabled state
then it will go from on to off.

Ingo

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/