Re: [PATCH] per-cpu patch 2/3

Robert Love (rml@tech9.net)
18 Jul 2002 10:05:26 -0700


On Wed, 2002-07-17 at 20:48, Rusty Russell wrote:
> Given the ongoing races with smp_processor_id() and preempt, this
> makes sense to me. this_cpu() was too generic a name anyway.

Very nice, although:

How do you reenable preemption?

We already have get_cpu() and put_cpu() which do pretty much what you
are suggesting (and put_cpu() enables preemption) and are used by code
today. If you want to make changes to them, that is fine, but we should
keep the interface...

Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/