Re: Remain Calm: Designated initializer patches for 2.5

[H. Peter Anvin]

Rusty Russell wrote:
> In message <[e-mail]> you write:
> 
>>As far as I could tell, *ALL* of these changes broke text alignment in 
>>columns.
> 
> 
> True.
> 
> 
>>It would have been a lot better if they had maintained spacing; I
>>find the new code much more cluttered and hard to read.
> 
> 
> I thought about this: I agree it doesn't look as neat, but "hard to
> read" for what purpose?  It's just as easy to find a particular field
> you're looking for and it's just as easy to find the end of the
> declaration: I couldn't come up with a convincing argument for needing
> to skim-read these declarations, so I didn't complain to the author.
> 

Neatness is about making it easy to read code *quickly*.  The pattern 
recognizer in your brain doesn't work as well on a jumbled mess.

	-hpa