Re: PS2 Input Core Support

Vojtech Pavlik (vojtech@suse.cz)
Wed, 17 Jul 2002 14:44:10 +0200


On Wed, Jul 17, 2002 at 02:41:45PM +0200, Udo A. Steinberg wrote:
> Vojtech Pavlik wrote:
> >
> > Ok, another patch. :)
>
> Very close :)
> Directions of scrolling are reversed. The following works ok:
>
> diff -Nru a/drivers/input/mouse/psmouse.c b/drivers/input/mouse/psmouse.c
> --- a/drivers/input/mouse/psmouse.c Wed Jul 17 12:19:13 2002
> +++ b/drivers/input/mouse/psmouse.c Wed Jul 17 12:19:13 2002
> @@ -142,7 +142,7 @@
> */
>
> if (psmouse->type == PSMOUSE_IMEX) {
> - input_report_rel(dev, REL_WHEEL, (int) (packet[3] & 8) - (int) (packet[2] & 7));
> + input_report_rel(dev, REL_WHEEL, (int) (packet[3] & 8) - (int) (packet[3] & 7));
> input_report_key(dev, BTN_SIDE, (packet[3] >> 4) & 1);
> input_report_key(dev, BTN_EXTRA, (packet[3] >> 5) & 1);
> }

Can you check with evtest again? Up should be showing as -1, down as 1.
If it doesn't, then there is another direction bug elsewhere.

-- 
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/