Re: [PATCH] agpgart splitup and cleanup for 2.5.25

Linus Torvalds (torvalds@transmeta.com)
Mon, 15 Jul 2002 11:23:24 -0700 (PDT)


On Mon, 15 Jul 2002, Dave Jones wrote:
>
> the .o files get linked into agpgart.o
> Still just one module. Christoph Hellwig proposed making each back
> end a module too, which is dependant upon agpgart.o, but that's more
> pain than I feel like enduring right now.. Maybe later.
>
> Linus ?

I'm perfectly happy with something like "via-agp.c", if it heads off
potential future trouble. I just don't like the "agpgart_be" thing, it's
unreadable in the first place, too long in the second, and having a prefix
(as opposed to a postfix) makes filename completion suck in the third
place.

Something like "via-agp.c" doesn't have any of those problems, and while
the "agp" is slightly redundant in the directory structure, it's at least
not ugly.

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/