Re: [PATCH] AFFS fix return without releasing BKL

[Dave Hansen]

This is a multi-part message in MIME format.
--------------050202000105010605000706
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Roman Zippel wrote:
> Hi,
> 
> On Thu, 11 Jul 2002, Dave Hansen wrote:
> 
>>This was found by Dan Carpenter <[e-mail]>, using an smatch
>>script.  Looks to me like like an error caused during all the BKL
>>pushing.  1 more coming...
> 
> Actually lock_kernel() and the test there can be removed completely.

Patch attached to do just that.

-- 
Dave Hansen
[e-mail]

--------------050202000105010605000706
Content-Type: text/plain;
 name="affs-bkl_ret-2.5.25-1.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="affs-bkl_ret-2.5.25-1.patch"

--- linux-2.5.25-clean/fs/affs/namei.c	Thu Jun 20 15:53:49 2002
+++ linux/fs/affs/namei.c	Fri Jul 12 12:05:24 2002
@@ -342,14 +342,7 @@
 	pr_debug("AFFS: rmdir(dir=%u, \"%.*s\")\n", (u32)dir->i_ino,
 		 (int)dentry->d_name.len, dentry->d_name.name);
 
-	lock_kernel();
-
-	/* WTF??? */
-	if (!dentry->d_inode)
-		return -ENOENT;
-
 	res = affs_remove_header(dentry);
-	unlock_kernel();
 	return res;
 }
 

--------------050202000105010605000706--