Re: [patch] sched-2.5.24-D3, batch/idle priority scheduling,

[Ingo Molnar]

On Sat, 6 Jul 2002 [e-mail] wrote:

> Hello.
> 
> I beleive this patch against entry.S should be sufficient:
> 
> --- entry.S~    Sat Jul  6 21:01:16 2002
> +++ entry.S     Sat Jul  6 21:06:14 2002
> @@ -255,7 +255,7 @@
>         testb $_TIF_NEED_RESCHED, %cl
>         jz work_notifysig
>  work_resched:
> -       call schedule
> +       call schedule_userspace
>         cli                             # make sure we don't miss an
> interrupt
>                                         # setting need_resched or
> sigpending
>                                         # between sampling and the iret
> 
> Both calls to schedule() at resume_kernel: and work_pending:
> have clear kernel/user return path.

agreed, good catch. This greatly simplifies things.

> And users of __KERNEL_SYSCALLS__ and kernel_thread() should not
> have policy == SCHED_BATCH.

yep. And even if they do they should be aware of the consequences.

	Ingo