Re: [linux-usb-devel] Re: usb storage cleanup

[Matthew Dharm]

--xA/XKXTdy9G3iaIz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Now... wait a second here....

You say the dirver "is supposed to wait until all urbs" are completed...
but we're talking about the case where the device is now gone...

So how do the urbs complete?  Something is causing them to complete when
the cable is removed -- that's the behavior I've observed, at least.

Matt

On Thu, Jul 04, 2002 at 01:23:54PM -0700, David Brownell wrote:
> >>Test case: user pulls out the usb cable while a transfer is in progress=
.=20
> >>urb submitted to the device, reply not yet received.
> >>Result: storage_disconnect() would hang for 20 seconds until=20
> >>command_abort() is called.
> >=20
> >=20
> > No, not quite.   The HCD accelerates the URBs to completion if the devi=
ce
> > is removed with an URB pending on it.  It therefore shouldn't hang for =
the
> > timeout -- if you're seeing this behavior, then the HCD is broken.
>=20
> Actually all of the interesting work is triggered by khubd,
> and then the device driver.
>=20
> Khubd calls usb_disconnect() for the device.  That disconnects
> each driver (which is supposed to wait until all urbs it's
> submitted have completed, and not submit any more URBS).
>=20
> Only at the very end of this does the HCD hear anything about
> devices going away.  If there's any URB still submitted at that
> point it's not a bug in the HCD at all ... but in a device
> driver that didn't implement disconnect() correctly.
>=20
> - Dave
>=20
>=20
>=20

--=20
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.=
net=20
Maintainer, Linux USB Mass Storage Driver

Way to go, lava boy.
					-- Stef to Greg
User Friendly, 3/26/1998

--xA/XKXTdy9G3iaIz
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9JLsqIjReC7bSPZARAoafAJ49I+rEB6QYuEoM8qalvOczuhmCIQCeJ2o/
vYhDxC1Gjd+rqSbklmbZrfA=
=nU96
-----END PGP SIGNATURE-----

--xA/XKXTdy9G3iaIz--