Re: BUG_ON(x) instead of if (x) BUG() in mm/page_alloc,swap_state.c

[Andrew Morton]

Lightweight patch manager wrote:
> 
> This replaces if(x) BUG() with BUG_ON(x) where necessarry, at least in
> mm/page_alloc.c and mm/swap_state.c

Thanks - I'll add to my pile.

> ...
> -                       if (!nr_pages--)
> -                               BUG();
> +                       BUG_ON(!nr_pages--)

Except for this chunk.  It's best to avoid putting statements
with side-effects inside BUG_ON().  If someone wants to build
a super-small kernel with a no-op BUG_ON() then code such as the
above will cause it to fail.

It'll probably fail anyway, but hey - may as well try.

-