Re: 2.4.19-rc1 broke OSF binaries on alpha

Kurt Garloff (garloff@suse.de)
Mon, 1 Jul 2002 09:54:18 +0200


--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Ivan, Alan, Marcelo,

On Sun, Jun 30, 2002 at 03:50:58AM +0400, Ivan Kokshaysky wrote:
> On Sat, Jun 29, 2002 at 03:28:50AM +0100, Alan Cox wrote:
> > Please back it back in. The bug is the Alpha port. Alpha needs its own =
OSF
> > readv/writev entry point which masks the top bits.
>=20
> Ouch. The new entry point just because of this?!
> Marcelo, if you're going to back in that patch, please apply
> the following on the top of it.

This patch indeed makes acroread & netscape work again on my alpha. Nice
spotting.
Don't we know about the type of binary? (Like personality ...)
So we could use something like
ssize_t len
#ifdef __alpha__
if (current->personality =3D=3D DEC_OSF_OLD)
len =3D (int) iov[i].iov_len;
else
len =3D (ssize_t) iov[i].iov_len;
#else
len =3D (ssize_t) iov[i].iov_len;
#endif

Not really beautiful, but working for all cases.

Regards,
--=20
Kurt Garloff <garloff@suse.de> Eindhoven, NL
GPG key: See mail header, key servers Linux kernel development
SuSE Linux AG, Nuernberg, DE SCSI, Security

--+QahgC5+KEYLbs62
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9IAqqxmLh6hyYd04RAuEyAKDVqVZ3EacioGqsRum49M5tUStOQACgnLyH
C29DWxfhT2/7N69j8ruvwlA=
=Gw5B
-----END PGP SIGNATURE-----

--+QahgC5+KEYLbs62--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/