Re: [PATCH] compile fix for 2.5 kdev_t compatibility macros

[Stephen Lord]

On Fri, 2002-06-28 at 09:37, Steven Cole wrote:
> On Fri, 2002-06-28 at 07:50, Stephen Lord wrote:
> > 
> > 
> > Marcelo,
> > 
> > We started using these for XFS, and found a missing bracket, patch
> > against 2.4.19-rc1.
> > 
> > Steve
> > 
> > *** linux-2.4.19-rc1/include/linux/kdev_t.h	Fri Jun 28 08:40:22 2002
> > --- linux/include/linux/kdev_t.h	Fri Jun 28 07:05:32 2002
> > ***************
> > *** 81,87 ****
> >   #define minor(d)	MINOR(d)
> >   #define kdev_same(a,b)	((a) == (b))
> >   #define kdev_none(d)	(!(d))
> > ! #define kdev_val(d)	((unsigned int)(d)
> >   #define val_to_kdev(d)	((kdev_t(d))
> >   
> >   /*
> > --- 81,87 ----
> >   #define minor(d)	MINOR(d)
> >   #define kdev_same(a,b)	((a) == (b))
> >   #define kdev_none(d)	(!(d))
> > ! #define kdev_val(d)	((unsigned int)(d))
> >   #define val_to_kdev(d)	((kdev_t(d))
> >   
> >   /*
> 
> That's an odd-looking patch.  Is this what you meant?
> 
> Steven
> 
> --- linux-2.4.19-rc1/include/linux/kdev_t.h.orig	Fri Jun 28 08:31:27 2002
> +++ linux-2.4.19-rc1/include/linux/kdev_t.h	Fri Jun 28 08:32:36 2002
> @@ -81,7 +81,7 @@
>  #define minor(d)	MINOR(d)
>  #define kdev_same(a,b)	((a) == (b))
>  #define kdev_none(d)	(!(d))
> -#define kdev_val(d)	((unsigned int)(d)
> +#define kdev_val(d)	((unsigned int)(d))
>  #define val_to_kdev(d)	((kdev_t(d))
>  
>  /*
> 

Yes, do not use diff before drinking coffee in the morning.

Steve