Re: Fragment flooding in 2.4.x/2.5.x

kuznet@ms2.inr.ac.ru
Fri, 28 Jun 2002 02:07:45 +0400 (MSD)


Hello!

> Are you seriously saying that all 'right' user applications should be testing
> the socket buffer congestion before sending a non-blocking UDP message rather
> than just testing sendmsg() for an EWOULDBLOCK return value???

I am saying absolutely seriously that there is nothing more stupid
than preparation of skbs only to drop them and to return you EAGAIN.
_Nothing_, do you hear this?

Repeating the third time in hope you eventually read the mail to the end:

>>>Better way exists. Just use forced sock_wmalloc instead of
>>>sock_alloc_send_skb on non-blocking send of all the fragments
>>>but the first.

And, yes, until this is done, I have to be serious when saying
that any application using nonblocking sockets have to use select()
or even SIOCOUTQ. Your patch does not change anything in this.

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/