Re: [PATCH] ATA: cleanup of channel->autodma flags usage

[Kees Bakker]

>>>>> "Bartlomiej" == Bartlomiej Zolnierkiewicz <[e-mail]> writes:

Bartlomiej> incremental to generic ATA PCI auto-dma patches...
[...]
Bartlomiej> 	- remove ATA_F_NOAUTODMA flag from aec62xx.c, hpt34x.c,
Bartlomiej> 	  sis5513.c and via82cxxx.c drivers, it's use was bogus
Bartlomiej> 	  in these drivers

Bartlomiej> 	  only two usages of ATA_F_NOAUTODMA are left (in ide-pci.c),
Bartlomiej> 	  probably they can alse be removed due to fact that drivers
Bartlomiej> 	  should disable autodma not ide-pci (i.e. hpt34x)
[...]

That should say: ATA_F_NOADMA

I have removed ATA_F_NODMA in ide-pci.c for my VIA8233
(PCI_DEVICE_ID_VIA_82C586_1). So far it has not failed (using 2.5.20).

--- linux-2.5.20/drivers/ide/ide-pci.c~	Mon Jun  3 14:49:59 2002
+++ linux-2.5.20/drivers/ide/ide-pci.c	Fri Jun  7 18:52:50 2002
@@ -742,8 +742,7 @@
 	{
 		vendor: PCI_VENDOR_ID_VIA,
 		device: PCI_DEVICE_ID_VIA_82C586_1,
-		bootable: ON_BOARD,
-		flags: ATA_F_NOADMA
+		bootable: ON_BOARD
 	},
 	{
 		vendor: PCI_VENDOR_ID_TTI,

- Kees