[FIX] Cannot mount FreeBSD partitions w/ 2.4.19-pre10-ac2

[Matthias Andree]

--k+w/mQv8wyuph6w0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Alan,

trying to mount a FreeBSD 4.6 partition on an IDE drive with Linux
2.4.19-pre10-ac2, I get this:

ufs_read_super: fragment size 1024 is too large

(I am using "mount -r -t ufs -o ufstype=3D44bsd /dev/MUMBLE /bsd" to mount).

I gather that your tree lacks Mikael Pettersson's trivial
bugfix from 2.5 (that is backported in 2.4.19-rc1), with this patch, I
can mount FreeBSD partitions fine.

I this will be fixed as you merge 2.4.19-rc1 anyways, but people might
find it useful until then:

--- linux/fs/ufs/super.c	Wed Jun  5 11:14:53 2002
+++ linux-2.4/fs/ufs/super.c	Thu Jun 27 11:32:46 2002
@@ -662,12 +662,12 @@
 			uspi->s_fsize);
 		goto failed;
 	}
-	if (uspi->s_bsize < 512) {
+	if (uspi->s_fsize < 512) {
 		printk(KERN_ERR "ufs_read_super: fragment size %u is too small\n",
 			uspi->s_fsize);
 		goto failed;
 	}
-	if (uspi->s_bsize > 4096) {
+	if (uspi->s_fsize > 4096) {
 		printk(KERN_ERR "ufs_read_super: fragment size %u is too large\n",
 			uspi->s_fsize);
 		goto failed;
@@ -679,7 +679,7 @@
 	}
 	if (uspi->s_bsize < 4096) {
 		printk(KERN_ERR "ufs_read_super: block size %u is too small\n",
-			uspi->s_fsize);
+			uspi->s_bsize);
 		goto failed;
 	}
 	if (uspi->s_bsize / uspi->s_fsize > 8) {

--=20
Matthias Andree

--k+w/mQv8wyuph6w0
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9Gvq7FmbjPHp/pcMRAqR6AJ9DdrlI7OZufciMTtv/ASER7gdHiwCZAReC
LMnJyLwEO+Cswg6zOxk79eI=
=/QKR
-----END PGP SIGNATURE-----

--k+w/mQv8wyuph6w0--