Re: Linux 2.4.19-rc1

[Marcelo Tosatti]

Simon,

This fix is on my BK tree since yesterday.

Thanks anyway

On Tue, 25 Jun 2002, Simon Kirby wrote:

> Hello,
>
> This fix did not yet make it in to the tg3 driver as of -rc1.  This patch
> fixes an occasional crash problem with several of our boxes and the tg3
> driver (fix from Jes).
>
> --
>
> Hi Dave
>
> Here's another one, tg3_recycle_rx() needs to declare dest_idx_unmasked
> as unsigned int or it will do funny stuff on modular division once we go
> above 31 bit values.
>
> I don't think this is the bug that Scott was hitting, but it is of
> course possible. It takes about 120 minutes for me with a packet
> generator, spewing out 64 byte packets, to trigger it.
>
> Cheers,
> Jes
>
> --- ../orig/drivers/net/tg3.c	Tue May 14 07:30:52 2002
> +++ drivers/net/tg3.c	Fri Jun 14 11:20:48 2002
> @@ -1689,7 +1669,7 @@
>   * tg3_alloc_rx_skb for full details.
>   */
>  static void tg3_recycle_rx(struct tg3 *tp, u32 opaque_key,
> -			   int src_idx, int dest_idx_unmasked)
> +			   int src_idx, u32 dest_idx_unmasked)
>  {
>  	struct tg3_rx_buffer_desc *src_desc, *dest_desc;
>  	struct ring_info *src_map, *dest_map;
>
> --
>
> Simon-
>
> [  Stormix Technologies Inc.  ][  NetNation Communications Inc. ]
> [       [e-mail]       ][       [e-mail]        ]
> [ Opinions expressed are not necessarily those of my employers. ]
>