On Fri, 7 Jun 2002, Jeff Garzik wrote:
> Thanks for the effort, that was a quick turnaround :)
>
> But unfortunately the patch is wrong.
>
> You need to use an index which counts _tulip_ boards, which implies that
> the index is local to the driver. Currently the only such counter is
> board_idx, which is a variable local to tulip_init_one().
Would you suggest
a) setting it in some global struct (tulip_private etc.)?
b) calling it "eth%d", dev->ifindex?
> I wonder who the heck this patch is from?? Mikael? The "Lightweight
> patch manager" seems neat, but a rather unfriendly person to reply to :)
You keep talking to me. It happens whenever I use sendpatch. I prefer not
to be determined as sender of my patches by grepping the list, but all
responses to patch@etc go to thunder@etc, which is me.
> Regards,
>
> Jeff
> P.S. A ChangeLog entry (in the patch, or to be cut-n-pasted) is missing
> also.
What do you suggest?
Regards,
Thunder
-- ship is leaving right on time | Thunder from the hill at ngforever empty harbour, wave goodbye | evacuation of the isle | free inhabitant not directly caveman's paintings drowning | belonging anywhere- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/