Re: [PATCH] remove suser()

[Robert Love]

On Thu, 2002-06-06 at 14:48, Pavel Machek wrote:

> > diff -urN linux-2.5.20/include/linux/compatmac.h linux/include/linux/compatmac.h
> > --- linux-2.5.20/include/linux/compatmac.h	Sun Jun  2 18:44:41 2002
> > +++ linux/include/linux/compatmac.h	Tue Jun  4 13:57:33 2002
> > @@ -102,8 +102,6 @@
> >  
> >  #define my_iounmap(x, b)             (((long)x<0x100000)?0:vfree ((void*)x))
> >  
> > -#define capable(x)                   suser()
> > -
> >  #define tty_flip_buffer_push(tty)    queue_task(&tty->flip.tqueue, &tq_timer)
> 
> This is not right I believe. You want to keep compatibility for older
> kernels.

Someone else said this, too.  I must misunderstand the point of this
file... it is used for compatibility with NEW code in OLD kernels? 
Confusing that we keep it in the NEW kernel, then.  I figured it was
just to keep compatibility in general, or allow OLD code to work in the
new kernels.

If the intention is to use this header with other, older, kernels... and
we really want to keep that in a new kernel... then yes - this bit
should be added back.

	Robert Love