Re: [PATCH] update for ALi Audio Driver (0.14.10)

Jeff Garzik (jgarzik@mandrakesoft.com)
Thu, 06 Jun 2002 14:09:35 -0400


Alan Cox wrote:

>On Thu, 2002-06-06 at 07:27, lei_hu@ali.com.tw wrote:
>
>
>>Dear all
>> I rewrite the part to read/write registers of the audio codec for Ali 5451
>>Audio Driver.
>>
>>
>
>The formatting seems to have gone a bit strange but I'll clean that up
>and merge the change
>
>

Why? Hardware semaphores are notorious for causing hangs. Nobody is
sharing the hardware under Linux, so I think we should enable access on
init, and not disable access until driver close. IMO the mixer should
be guarded by a Linux kernel semaphore... I have a patch from Thomas
Sailer (I think) lying around somewhere that does just that to the via
audio driver. Maybe we can adapt it.
(I cc'd this little detail, in my ali/trident.c patch review, to you)

Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/