Re: [PATCH] 2.5.20 IDE 85

[Martin Dalecki]

Jens Axboe wrote:
> On Wed, Jun 05 2002, Jens Axboe wrote:
> 
>>On Wed, Jun 05 2002, Martin Dalecki wrote:
>>
>>>Jens Axboe wrote:
>>>
>>>>On Wed, Jun 05 2002, Martin Dalecki wrote:
>>>>
>>>>AFAICS, you just introduced some nasty list races in the interrupt
>>>>handlers. You must hold the queue locks when calling
>>>>blkdev_dequeue_request() and end_that_request_last(), for instance.
>>>>
>>>
>>>No. Please be more accurate. Becouse:
>>>
>>>1. If anything I have made existing races only "obvious".
>>
>>If anything, you've made a race you introduced earlier more obvious.
>>
>>
>>>2. It is called in the context of do_ide_request or ide_raw_taskfile
>>>   where we already have the lock.
>>
>>?? Both tcq and ata_special_intr look like interrupt handlers to me.
> 
> 
> BTW, I wanted to look at the code (and not just read the patch), but
> it's not clear from the patch what it is against. Where do you keep
> older patches so I can get them? Maybe the ide code could do with a bit
> of peer review :-)
> 

Well IDE 83 and 84 are already inside the bk repository at linux.bkbits.com.
No as far as of now I don't have any public FTP or whatever area for
the patches (Well send you everything in one go.)
And I of course agree that the code needs a peer review in this area.
Adding the locking isn't difficult.
However I wonder a bit whatever we couldn't just blkdev_dequeue_request()
once at request handling start? We drag drive->rq around anyway...