Bug in asm-i386/rwlock.h

Alexey Vyskubov (alexey.vyskubov@nokia.com)
Tue, 4 Jun 2002 17:08:55 +0300


Hello.

We suppose that include/asm-i386/rwlock.h contains a bug.

Under some circumstances (compiling some external modules + no
optimization + SMP) it's possible to get the following error:

/tmp/ccw7qDe1.s: Assembler messages:
/tmp/ccw7qDe1.s:6815: Error: bad expression
/tmp/ccw7qDe1.s:6815: Error: missing ')'
/tmp/ccw7qDe1.s:6815: Error: missing ')'
/tmp/ccw7qDe1.s:6815: Error: junk `ebx))' after expression

We believe that it's a typo in include/asm-i386/rwlock.h

--- include/asm-i386/rwlock.h.orig Tue Jun 4 16:32:38 2002
+++ include/asm-i386/rwlock.h Tue Jun 4 16:33:02 2002
@@ -61,7 +61,7 @@
::"a" (rw) : "memory")

#define __build_write_lock_const(rw, helper) \
- asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",(%0)\n\t" \
+ asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",%0\n\t" \
"jnz 2f\n" \
"1:\n" \
".section .text.lock,\"ax\"\n" \

-- 
Alexey Vyskubov
Dmitry Kasatkin
Nokia Research Center / Helsinki
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/