> His patch won't match for 2.5. I just adapted it, even though I've had a
> typo there.
That would be because the one in 2.5 is quite a few revisions behind
(perhaps 2-3 patches)
> > > + opl3sa2_state[card].activated = 1;
> >
> > This line should really be below the following if statement, as I believe
> > Zwane mentioned to Gerald.
>
> You could of course have it there. No problem with that.
If you put it there you'd have to unset it on a failure path.
Regards,
Zwane Mwaikambo
-- http://function.linuxpower.ca
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/