Re: Atomic operations

[H. Peter Anvin]

Followup to:  <[e-mail]>
By author:    Brian Gerst <[e-mail]>
In newsgroup: linux.dev.kernel
> 
> int atomic_xadd(int i, atomic_t *v)
> {
> 	int ret;
> 	__asm__(LOCK "xaddl %1,%0"
> 		: "=m" (v->counter), "=r" (ret)
> 		: "0" (v->counter), "1" (i));
> 	return ret;
> }
> 
> This one only works on 486+, but there are practically no real 386 SMP
> systems.
> 

<slaps forehead>

Boy do I feel dumb now.

The only nitpick is that it's probably better coded as:

int atomic_xadd(int i, atomic_t *v)
{
	asm volatile(LOCK "xaddl %1,%0"
		: "+m" (v->counter), "+r" (i));
	return i;
}
-- 
<[e-mail]> at work, <[e-mail]> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt	<[e-mail]>