Re: [PATCH] kernel 2.4.18 endianness logical mistakes correction onfbcon-cfb2.c and fbcon-cfb4.c

[(no name)]

> > This patchs correct the endianness logical of nibbletab, the first table
is
> > u_char mades so no endian needed and the second swap correctly bytes in
> > LITTLE_ENDIAN. (old version swap half bytes instead of bytes).
>
> For pixels smaller than a byte, it also depends on what's the order of the
> pixels in a byte. So all possibilities are actually possible.

All is possible but for LITTLE ENDIAN and BIG ENDIAN are clearly defined by
the swap of bytes only and not the order of bytes, you can't use the same
definition LITTLE_ENDIAN for swapping bytes in part of hardware (0xABCD ->
0xCDAB) and swapping bytes orders in overs hardwares parts (0xABCD ->
0xDCBA). I suppose this swap order has been introduced for specifics
hardwares requirements, it's ok but only with another option than LITTLE
ENDIAN, since it's incoherent.

François.